Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: Remove TwoTone icons #19666

Merged
merged 1 commit into from
Apr 12, 2022
Merged

chore: Remove TwoTone icons #19666

merged 1 commit into from
Apr 12, 2022

Conversation

geido
Copy link
Member

@geido geido commented Apr 12, 2022

SUMMARY

Antdesign TwoTone icons are unused in the application. In order to avoid misuse of these icons, this PR filters them out.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual changes

TESTING INSTRUCTIONS

  1. Open Storybook and make sure no TwoTone icons are present

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido requested a review from michael-s-molina April 12, 2022 13:08
michael-s-molina
michael-s-molina approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #19666 (eb98d24) into master (87d4798) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #19666   +/-   ##
=======================================
  Coverage   66.47%   66.47%           
=======================================
  Files        1681     1681           
  Lines       64467    64468    +1     
  Branches     6607     6607           
=======================================
+ Hits        42856    42857    +1     
  Misses      19917    19917           
  Partials     1694     1694
Flag Coverage Δ
javascript 51.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/components/Icons/AntdEnhanced.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d4798...eb98d24. Read the comment docs.

@geido geido merged commit 6a3220f into apache:master Apr 12, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@geido @philipher29
Remove TwoTone icons (apache#19666)
5ac2e38
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geido @michael-s-molina @mistercrunch